Pass the build arguments through to new_element_path. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test case that demonstrates the error & its fix? |
|
@jeremy I'm happy with this now if you are. |
|
Thanks @seanhandley. Could you push a single squashed commit? |
Failing to do this leads to bad requests for nested element paths so an api with self.site set to be 'foo.com/customers/:customer_id/items/:item_id' will generate the url /customers//items/new.json when Item.build is called and the API returns an error code. If we pass the attributes from build to new_element_path, this behaviour is corrected such that build calls the url: /customers/1/items/new.json
|
All done @jeremy |
jeremy
added a commit
that referenced
this pull request
Oct 25, 2012
Pass the build arguments through to new_element_path.
|
I ran into the same issue. Great to see this was taken care of already. Cheers. |
|
@mvlwn I'm glad - thanks for saying so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to pass the attributes to new_element_path in the self.build method leads to bad requests for nested element paths.
For example, an api with self.site set to be
will generate the url
when Item.build is called and the API returns an error code as a result.
If we pass the attributes from self.build through to new_element_path, this behaviour is corrected and build uses the correct url to initialise the empty ActiveResource object.